Handle empty arrays in -in and -between in subclasses #22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subclasses that override
_where_field_INand_where_field_BETWEENand conditionally re-dispatch to the default handlers in SQL::Abstract were not correctly handling empty array references passed as arguments to-in,-between, and their negated counterparts.This behaviour was broken in the refactor that lead to 2.000000, and more specifically in 1.90_03, going from
to
and resulting in illegal SQL.
This was breaking behaviour that resulted in downstream issues affecting at least SQL::Abstract::More (see damil/SQL-Abstract-More#20).
Likewise, a class overriding
_where_field_BETWEENwas not triggering the parameter validation that disallowed empty array references or undefined values to be used as parameters to-betweenand its negation:This change ensures that the path taken by subclasses that override those methods triggers equivalent code paths to those that don't.
Fixes https://rt.cpan.org/Ticket/Display.html?id=142341