Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trailing whitespace in header comments #113

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dboehmer
Copy link
Contributor

In my case SQL::Translator creates SQL-files for SQLite with trailing whitespace in empty comment lines.

I suggest fixing that by removing the single space from $DEFAULT_COMMENT and prefixing any comments with the space again.

I hope that $DEFAULT_COMMENT is not too important or too widely used to be changed.

@codecov
Copy link

codecov bot commented Nov 27, 2018

Codecov Report

Merging #113 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #113   +/-   ##
======================================
  Coverage    21.5%   21.5%           
======================================
  Files          71      71           
  Lines       19914   19914           
  Branches     5728    5728           
======================================
  Hits         4283    4283           
  Misses      14922   14922           
  Partials      709     709
Impacted Files Coverage Δ
lib/SQL/Translator/Utils.pm 67.44% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86c68a0...3e4fee8. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant