implemented materialized views for pg #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rabbiveesh
changed the title
|
See also Oracle materialized view support in 8d59dd5 which allows to specify options. |
|
as per https://www.postgresql.org/docs/10/sql-creatematerializedview.html there aren't any materialized-view specific options, just a slightly limited set of table options. |
|
Being able to specify the WITH parameter would make sense. |
|
it's a subset of what's available on table creation. It doesn't seem like
there's an interface for that on tables either, so I don't think it would
affect this PR.
It's different than Oracle, which has options in the with clause that
affect deployment of the view, these things in the with clause are about
the table in general.
…On Thu, Nov 21, 2019 at 9:43 AM Alexander Hartmaier < ***@***.***> wrote:
Being able to specify the WITH parameter would make sense.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#120?email_source=notifications&email_token=AFURPKXIX5PPUSML34EI4IDQUY3YLA5CNFSM4JPZSTWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEZI2AI#issuecomment-556961025>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFURPKQJC4V23O5KQLIGJ3DQUY3YLANCNFSM4JPZSTWA>
.
|
rabbiveesh
force-pushed
the
rabbiveesh/material_pg
branch
from
222501e
to
4b8a5ef
Compare
|
Looks good to me. I do worry about all the |
mohawk2
approved these changes
Nov 30, 2020
…bbiveesh/material_pg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a beginning implementation of materialized view for PG.
I assume this sort of contribution is wanted.
What do you think, the docs say you can't make a temporary materialized view. So should this mean that the materialized view should be created and it'll drop the temporary, it should only do temporary and not materialized, or die a horrible death?