Fix Travis builds by asking for postgres #122
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Builds in Travis currently fail with
The command "psql -U postgres -c 'create database sqlt_test;'" failed and exited with 2 during .
https://travis-ci.org/davel/sql-translator/jobs/624123545
When Makefile.PL is run the second time, after dependencies have been installed, it does not generate the test data, and so the run fails with, https://travis-ci.org/davel/sql-translator/jobs/624129330 This only seems to happen on perl 5.16 and 5.18.
|
The change installing postgresql was merged in 43571d2 and appears to have fixed the Travis build. It is not known why d05976b is no longer needed, but the failure seen before can be seen at https://travis-ci.org/dbsrgits/sql-translator/builds/624133664 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Travis builds are currently failing with
eg., https://travis-ci.org/davel/sql-translator/jobs/624123545
This change requests for postgres to be available.
The tests on Perl 5.16 and 5.18 are also failing because insufficient dependencies are installed the first time Makefile.PL is invoked, so that the test data does not get generated. A second change causes the test data to be generated if it is not present on the second run of Makefile.PL.