SQLite and MySQL parser to understand CHECK with parens #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohawk2
force-pushed
the
sqlite-constraints
branch
from
00024de
to
bc769ef
Compare
mohawk2
changed the title
|
Now also fixes similar but worse problem with Parser::MySQL, which didn't understand CHECK constraints. and now does, as reported by TBSliver. |
|
And now also supports MariaDB's defaults that can be other columns. |
|
Woo! looks good and works for both my test case and production SQL - excellent :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the SQLite parser fails on CHECK constraints that are effectively enums. This fixes that.