Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for covering index (INCLUDE) on PG producer #131

Merged
merged 7 commits into from Aug 9, 2021

Conversation

rabbiveesh
Copy link
Contributor

This adds support for covering indices (i.e. the "INCLUDE" clause on create index) for the Postgres producer.

the intended interface is as follows

$table->add_index(
   name => 'covering', fields => [ 'foo' ], 
   options => { include => [ 'bar', 'baz' ] }
);

In the current implementation it silently skips the clause if PG is under
version 10, b/c it was only added in 11 (as far as I remember). I'm not quite
sure if it should be that way, or if it should die.

@rabbiveesh
Copy link
Contributor Author

The only thing left here is to improve the docs with the updated index grammar.

@rabbiveesh rabbiveesh merged commit 28b4de0 into dbsrgits:master Aug 9, 2021
@rabbiveesh rabbiveesh deleted the rabbiveesh/pg-covering-index branch August 9, 2021 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant