Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix passing of producer args from SQL::Translator::Diff." #138

Merged
merged 4 commits into from
Jul 8, 2022

Conversation

rabbiveesh
Copy link
Contributor

Reverts #117

broke the tests for SQLT-Diff, producer_args really is args for SQLT directly

@rabbiveesh
Copy link
Contributor Author

@racke sorry, had to revert your PR.

For now, to accomplish your use case, you need to pass producer_args as a key to producer_args.

I'm going to make a different key that changes the API to use sqlt_args instead of producer_args so that this is more obvious, and it'll warn on the old usage.

@rabbiveesh rabbiveesh merged commit 2fb673e into master Jul 8, 2022
@rabbiveesh rabbiveesh deleted the revert-117-pr/fix-producer-args-todo branch July 8, 2022 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant