Jump to conversation
Unresolved conversations (0)
Nice work!

Nice work!

All of your conversations have been resolved.

Resolved conversations (5)
@rabbiveesh rabbiveesh Sep 28, 2022
just to get this straight: this is special casing CURRENT_TIMESTAMP b/c it's a magic constant in the Oracle grammar, and you don't want SQLT to quote it down the line? If that's the case, I don't know if this is the right place to take care of special casing it here. If you look at the SQLite parser, they special case it in the rule for `VALUE`, which makes more sense to me.
lib/SQL/Translator/Parser/Oracle.pm
hazardv rabbiveesh
@rabbiveesh rabbiveesh Sep 28, 2022
hey, why did you change this line? It looks to me like the way it's meant to be used is to passthrough args to SQLT::Diff, one arg of which is the args which are passed down to the inner SQLT instance
Outdated
lib/SQL/Translator/Diff.pm
rabbiveesh hazardv
@mohawk2 mohawk2 Sep 9, 2022
I don't think `warn` in tests is good practice?
Outdated
t/54-oracle-sql-diff.t
hazardv
@mohawk2 mohawk2 Sep 9, 2022
I don't think it's good practice to leave slabs of commented code. If you want to delete it, delete it.
Outdated
lib/SQL/Translator/Producer/Oracle.pm
hazardv
@mohawk2 mohawk2 Sep 9, 2022
"CAlling" typo
Outdated
lib/SQL/Translator/Producer/Oracle.pm
hazardv