Support for remaining FK ON UPDATE/ON DELETE actions #21
Conversation
…s for SQLite. According to the documentation this should be all of them (with the existing support of CASCADE and RESTRICT).
|
I forgot to mention it but on a fresh git clone, "prove -lrvm t/60roundtrip.t" always fails because of a missing file. I assume the file is generated by the build script, but the inc/ directory is also missing from the repository. The README also mentions a Build.PL script which is evidently not there anymore. |
|
Finally merged as 565563b9. Sorry for the delay. |
|
As far as your other notes - this distribution uses Module::Install. It is very common and very easy to work with - you simply need to have it installed, and then you run Note that I grepped throughout the distribution and did not find any references to Build.PL. Can you point out where you saw these? |
|
Well, the README mentioned Build.PL pretty explicitly. But there doesn't seem to be a README in the repo now. It was there when I forked, though, and you can still find it in past changesets. |
|
Ah right, the readme is now autogenerated from the main pod (which has since been edited): c45d3cb Any other issues with the dist as seen in the repo and/or the dist https://metacpan.org/release/SQL-Translator ? |
Hi,
This patch should add the missing support for ON UPDATE (resp. DELETE) SET NULL, SET DEFAULT and NO ACTION. So far only ON UPDATE CASCADE and ON UPDATE RESTRICT were implemented because they were the only ones matching the grammar (ON UPDATE \w+ did not match actions with spaces).
As a side effect it also restricts ON UPDATE and ON DELETE to only be valid actions as per the SQLite grammar here: http://www.sqlite.org/lang_createtable.html (as before this I assume ON UPDATE STUFF happily parsed to is($constraint->on_update, "STUFF")).