Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add_index expects an array ref not a array ref of stringified array refs... #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kiwiroy
Copy link

@kiwiroy kiwiroy commented Dec 18, 2012

That is to say that running

sqlt -f DBI --dsn 'dbi:Pg:host=<hostname>;dbname=<dbname>' --db-user '<db-user>' -t MySQL

results in

CREATE TABLE `migrate_version` (
  `repository_id` text NOT NULL,
  `repository_path` text NULL,
  `version` integer NULL,
  UNIQUE INDEX `migrate_version_pkey` (`ARRAY(0xa923264)`)
);

Other parsers effected is unknown and only the PostgreSQL DBI parser was investigated

This patch fixes this ensuring the result is

CREATE TABLE `migrate_version` (
  `repository_id` text NOT NULL,
  `repository_path` text NULL,
  `version` integer NULL,
  UNIQUE INDEX `migrate_version_pkey` (`repository_id`)
);

Review on Reviewable

…efs [ARRAY(0x123456)]

Signed-off-by: Roy Storey <roy.storey@plantandfood.co.nz>
@ribasushi
Copy link
Contributor

Can I please get an addition to t/66-postgres-dbi-parser.t with that? Thank you!

@frioux
Copy link
Member

frioux commented Oct 30, 2013

emailed author for tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants