Backward-compatible sqlite autoincrement

[basiliscos]

Hello,

Here is another attempt to introduce sqlite monotonic autoincrement which tries to be back-compatible.

Without extending SQL::Translator::Schema::Field I decided to use extra field to store type of autoincrement, which later could be re-used from Producer.

I hope this would be OK.

I tried to use it directly in DBIx::Class :

{ data_type => "integer", is_auto_increment => 1, is_nullable => 0, extra => { autoinc_method => 'sequence' } }

• it works that way. But how to specify extra more correctly in DBIx::Class? i..e outside of auto-generated sources?

Thanks for the great project!

[ilmari]

SQL::Translator::Parser::SQLite currently only sets is_auto_increment for AUTOINCREMENT columns. Arguably it should set that for INTEGER PRIMARY KEY columns as well, and add extra => { autoinc_method => 'sequence' } if the column is declared with AUTOINCREMENT.

I also think that, for consistency, the extra field should be auto_increment_method.

[basiliscos]

OK, I have renamed auto_increment_method in extra field.

Should I enhance SQL::Translator::Parser::SQLite too, as described above? I ask that because it seems to be breaking compatibilty?

[ilmari]

This is not actually valid in SQLite, AUTOINCREMENT can only be used immediately after INTEGER PRIMARY KEY, so field_autoinc() should be checking $self->_ipk($field) as well as $field->is_auto_increment and auto_increment_method.

[ilmari]

Enhancing Parser::SQLite can be done separately. I don't consider fixing parser bugs/limitations that improve the fidelity of the parsed schema and fix round-tripping to be backwards-compatibility breakage.

[basiliscos]

Indeed. Thanks for noting that.

[ribasushi]

Hi, just looked over this in depth.

The patch itself is good, naming not so much. Would you be opposed to the following changes:
auto_increment_method => auto_increment_type
and sequence => monotonic

[ribasushi]

Applied with proposed changes as 7f3f64d. Thank you!

[karupanerura]

Great 👍!
I need it. When it release to CPAN?

[ribasushi]

On 10/12/2015 08:34 AM, karupanerura wrote:

Great 👍!
I need it. When it release to CPAN?

In about another week. Sorry for the delay with this :/