New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed readme_from #69

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@upasana-me

upasana-me commented Sep 4, 2015

Module::Install doesn't have readme_from,
the deleted line gives error while doing perl Makefile.PL

readme_from was removed from Module::Install in 2011,
so I'm sure you people must be aware of it.

If removing the usage of readme_from is not the way to go, then
I'd like to know how to run tests (because I planned to write some missing test cases, initially).
I couldn't find any documentation for
this. Please let me know if I can document anything, I will try to do!

Removed readme_from
Module::Install doesn't have readme_from,
the deleted line gives error while doing `perl Makefile.PL`
@ribasushi

This comment has been minimized.

Show comment
Hide comment
@ribasushi

ribasushi Sep 10, 2015

Member

Sorry for the delayed reply. In order to execute the Makefile.PL you need to install Module::Install::ReadmeFromPod. I agree hat it is not readily apparent, and is generally confusing to newcomers.

I am however not merging this hange, as there is work underway to simplify and streamline the build-side of SQL::Translator. This work should be finished some time next week, so it makes little sense to go the extra mile to replace the line you removed.

Thus I am closing this PR without action, please install the module I mentioned earlier and continue onto what you were trying to do in the first place.

Cheers!

Member

ribasushi commented Sep 10, 2015

Sorry for the delayed reply. In order to execute the Makefile.PL you need to install Module::Install::ReadmeFromPod. I agree hat it is not readily apparent, and is generally confusing to newcomers.

I am however not merging this hange, as there is work underway to simplify and streamline the build-side of SQL::Translator. This work should be finished some time next week, so it makes little sense to go the extra mile to replace the line you removed.

Thus I am closing this PR without action, please install the module I mentioned earlier and continue onto what you were trying to do in the first place.

Cheers!

@ribasushi ribasushi closed this Sep 10, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment