Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- Added warning checks to SQL::Translator::Parser::DB2::Grammar. #73

Closed
wants to merge 1 commit into from

Conversation

manwar
Copy link
Contributor

@manwar manwar commented Nov 1, 2015

Hi @ilmari,

Please review the above changes.

Many Thanks.

Best Regards,
Mohammad S Anwar

@ribasushi
Copy link
Contributor

Thank you very much for your contribution @manwar. Unfortunately this patch can not be accepted as it modifies what is essentially generated code (SQL::Translator::Parser::DB2::Grammar is a product of a Parse::RecDescent compilation). It would be too risky to add warnings to an already egregious "tower of pisa", while offering very little benefit.

As such I am closing this PR without further action.

Please don't be discouraged by this rejection, you simply happened to touch "the wrong file".

Cheers!

@ribasushi ribasushi closed this Nov 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants