Providing IF NOT EXISTS to MySQL producer #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add some tests, can't merge it like that. |
|
Sawyer - any chance we can get some tests to go with that? |
|
I'll sit on it tonight. |
|
I'll submit a new PR updated with the current structure (Moo'ified, etc.) and tests. |
|
aight, closing this for now then |
|
Let's admit it. I won't get to it anytime soon. This is just sitting as a tab. I personally had no need for it. Someone else did. If the issue is ever raised again, it's worth revisiting. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MySQL (and SQLite, actually) support IF NOT EXISTS for table creation so it doesn't crash the DB. However, this isn't supported in SQL::Translator.
This pull request adds it to MySQL, sans tests and SQLite support.