Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Removed line about using condition #58

Merged
merged 1 commit into from
Feb 4, 2022

Conversation

bthomson22
Copy link
Contributor

Our style guide had a line in it about not using the using logic for joins. We've determined that this is no longer the case and can (and should) be used.

Copy link
Member

@aescay aescay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bthomson22 bthomson22 merged commit 169639d into master Feb 4, 2022
@bthomson22 bthomson22 deleted the fix/join-logic-dbt-style-guide branch February 4, 2022 01:56
@jtcohen6
Copy link

jtcohen6 commented Feb 4, 2022

good news everyone!!

megcolon pushed a commit that referenced this pull request Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants