Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #7273: enable dbt show for seeds #7544

Merged
merged 3 commits into from
May 8, 2023
Merged

fix #7273: enable dbt show for seeds #7544

merged 3 commits into from
May 8, 2023

Conversation

aranke
Copy link
Member

@aranke aranke commented May 8, 2023

resolves #7273

Description

Checklist

@aranke aranke requested a review from a team May 8, 2023 11:49
@aranke aranke requested review from a team as code owners May 8, 2023 11:49
@aranke aranke requested review from ChenyuLInx, emmyoop and davidbloss and removed request for a team May 8, 2023 11:49
@cla-bot cla-bot bot added the cla:yes label May 8, 2023
@aranke aranke requested review from stu-k and iknox-fa and removed request for emmyoop and davidbloss May 8, 2023 11:56
Copy link
Contributor

@stu-k stu-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nitpick, nothing else stands out 👍

core/dbt/task/show.py Outdated Show resolved Hide resolved
Copy link
Contributor

@iknox-fa iknox-fa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aranke aranke merged commit 881437e into main May 8, 2023
@aranke aranke deleted the fix_7273 branch May 8, 2023 22:08
@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2023

The backport to 1.5.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.5.latest 1.5.latest
# Navigate to the new working tree
cd .worktrees/backport-1.5.latest
# Create a new branch
git switch --create backport-7544-to-1.5.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 881437e89087b23dd1fb205ab6655a71e5075355
# Push it to GitHub
git push --set-upstream origin backport-7544-to-1.5.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.5.latest

Then, create a pull request where the base branch is 1.5.latest and the compare/head branch is backport-7544-to-1.5.latest.

@aranke aranke mentioned this pull request May 9, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-2373][Bug] dbt show doesn't work for seeds
4 participants