Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dbt date shims (pt 2) #40

Merged
merged 49 commits into from
Apr 29, 2021
Merged

Add dbt date shims (pt 2) #40

merged 49 commits into from
Apr 29, 2021

Conversation

dataders
Copy link
Contributor

shim dbt-date, the macros and all tests in dbt-date's integration tests project! #36. All credit to @b-per here, I shamelessly stole their macros.

@JCZuurmond I'm cringing at repetition in circleci/config.yml. perhaps you can help toxify for in a future PR?

@dataders dataders merged commit d1c741e into main Apr 29, 2021
@b-per
Copy link
Contributor

b-per commented Apr 30, 2021

Thanks @swanderz for merging this and the dbt-expectations macros within tsql-utils ! Can't wait to test it quickly on my side.

Is there anything else that you would need from me around those shims or is it all good? If those are done I might try to tackle some of the last missing dbt-utils macros.

@dataders
Copy link
Contributor Author

@b-per #44 is all set up for starting to shim dbt-expectations, if you check out CI test output you can see the places to start.

On your local set up you'll just want to call dbt deps/run/test from the tsql-utils' integration_tests/dbt_expectations folder. Reach out if you have questions, but also to be sure to browse the dbt-utils shims for techniques we've used before like for kwargs and working around unsupported syntax in the parent project's schema test defs.

@dataders dataders deleted the add-dbt-date branch November 12, 2021 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants