Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

building the initial bundle #6

Closed
wants to merge 2 commits into from
Closed

building the initial bundle #6

wants to merge 2 commits into from

Conversation

dbu
Copy link
Collaborator

@dbu dbu commented Aug 30, 2015

fix #1

feedback highly welcome @sagikazarmark @egeloen

my idea is to get this running when i return from holidays in 2 weeks and then contribute the bundle to the php-http organization. then we can work on porting more features from ivory into the new structure.


## Usage

TODO: move this to php-http-documentation? or keep it here?
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. I tend to follow the following practice: usage section contains a small description about the package, the documentation section contains a link to the relevant documentation. Like here

@@ -0,0 +1,82 @@
<?php

/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File headers like this should be removed. (At least I started to remove them from all files, because it does not contain any relevant information IMHO). Only author docblocks should be preserved on classes.

Copy link
Collaborator Author

@dbu dbu Aug 30, 2015 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sagikazarmark
Copy link
Member

👍 Added a "few" comments, mainly about standards.

@dbu
Copy link
Collaborator Author

dbu commented Aug 30, 2015 via email

@sagikazarmark
Copy link
Member

No problem. I will try to prepare the terminology PR until then so you can also review it before merging. (BTW, if you can quickly review the exception branch before going on holiday, I would be very thankful).

Enjoy your holiday. 😎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MVP
2 participants