Skip to content

Conversation

@dbudwin
Copy link
Owner

@dbudwin dbudwin commented Nov 1, 2023

This PR accomplishes a few things:

  • Update dev dependencies to use the latest version
  • Improve some unit tests by making them more specific/covering accessibility options
  • Fix potential bug where users may try to override the target attribute on links which could compromise the effectiveness of this package
  • Switch to using yarn over NPM

@github-actions
Copy link

github-actions bot commented Nov 1, 2023

Coverage after merging Updates into main

100.00%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
src
   index.tsx100%100%100%
src/components
   index.tsx100%100%100%
   secure-link.tsx100%100%100%

@github-actions

This comment has been minimized.

@github-actions
Copy link

github-actions bot commented Nov 1, 2023

Coverage after merging Updates into main

100.00%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
src
   index.tsx100%100%100%
src/components
   index.tsx100%100%100%
   secure-link.tsx100%100%100%

@github-actions

This comment has been minimized.

@dbudwin dbudwin changed the title Updates Package updates and disallow setting target attribute Nov 1, 2023
@dbudwin dbudwin merged commit c614fbb into main Nov 1, 2023
@dbudwin dbudwin deleted the Updates branch November 1, 2023 13:59
@github-actions
Copy link

github-actions bot commented Nov 1, 2023

Unit Test Results

  1 files  ±0    1 suites  ±0   3s ⏱️ -1s
18 tests ±0  18 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit c614fbb. ± Comparison against base commit 84df4d8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants