Set rust MSRV to 1.70 #191
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-sheets
approved these changes
Apr 21, 2023
|
One interesting thing that's come to my intention here is that if we set MSRV, clippy won't recommend lints using features above our MSRV. On one hand, that's reasonable, but on the other, we would like to know about the opportunity to take advantage of new features. Ideally we could still set MSRV, so it's available for people trying to build Cascade, but also get lint suggestions that would change the MSRV. This item is about that rust-lang/rust-clippy#10709 (reply in thread). So perhaps that sort of feature is coming soon. |
dburgener
force-pushed
the
dburgener/rust-msrv
branch
from
c3fbdd6
to
150ebc2
Compare
Also update CI to test it and ensure future compatibility
This is required for dependency clap
This was breaking the 1.7 check. It's not overly clear to me why it wasn't breaking more than just that.
dburgener
force-pushed
the
dburgener/rust-msrv
branch
from
42254ed
to
8c8ce3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also update CI to test it and ensure future compatibility