Remove transitive dependencies #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-sheets
approved these changes
May 2, 2023
dburgener
force-pushed
the
dburgener/regex-deps
branch
from
9aa9618
to
ab11efa
Compare
This reverts commit b9c4871.
This was recommended by the lalrpop documentation, but is actually a transitive dependency, not a real one. With lalrpop 0.19.12 this is now handled correctly on the lalrpop end. Lalrpop 0.20 will add support for a "unicode" feature to handle the whole regex dependency situation even more cleanly, so we will need to do a little tweaking to our dependencies at that point. But this is expected to be good for semver compatible ^0.19.12
Prior versions expose transitive regex unicode feature dependencies to us
dburgener
force-pushed
the
dburgener/regex-deps
branch
from
ab11efa
to
6b10abd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These existed to work around lalrpop bugs in dependency tracking. As of lalrpop 0.19.12, those bugs are resolved, so we don't need to explicitly include transitive lalrpop dependencies anymore. Lalrpop 0.20 will include further enhancements here, and we will need to either opt into the lalrpop "unicode" feature, or remove our dependence on the underlying unicode support, which is created somewhat accidentally from the use of the "\s" token in regexes.
I'm undecided on taking this for 0.1 at this point given how close we are and how new a release lalrpop 0.19.12 is, however I don't have a strong reason not to.