Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC 5229] Variable names aren't validated #43

Closed
dburkart opened this issue May 15, 2019 · 2 comments
Closed

[RFC 5229] Variable names aren't validated #43

dburkart opened this issue May 15, 2019 · 2 comments
Assignees
@dburkart
Labels
bug
Milestone
Version 0.7

Comments

@dburkart
Copy link
Owner

The first argument to the "set" action is a quoted string, but it actually needs to validate to these rules:

variable-name       =  num-variable / identifier
num-variable        =  1*DIGIT
@dburkart dburkart added the bug label May 15, 2019
@dburkart dburkart added this to the Version 0.7 milestone May 15, 2019
@dburkart dburkart self-assigned this May 15, 2019
dburkart added a commit that referenced this issue May 15, 2019
@dburkart
Validate variable names specified in the "set" action.
739b405 
Fixes issue #43.
@dburkart
Copy link
Owner Author

Reopening -- looks like this broke linux workers.

@dburkart dburkart reopened this May 15, 2019
@dburkart dburkart mentioned this issue May 15, 2019
Closed
@dburkart
Copy link
Owner Author

For now I've disabled this checking on Linux, and filed issue #44 to track the ultimate fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dburkart dburkart

Labels
bug
Projects
None yet
Milestone
Version 0.7
Development

No branches or pull requests
1 participant
@dburkart