Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to dbus-next #15

Merged
merged 7 commits into from Mar 4, 2019
Merged

Migrate to dbus-next #15

merged 7 commits into from Mar 4, 2019

Conversation

@acrisci
Copy link
Member

@acrisci acrisci commented Nov 8, 2018

Migration to dbus-next (a fork of dbus-native) is a rewrite, but fixes
some outstanding bugs in the project related to variant types.

The project is now transpiled to use the experimental decorator feature
that will be available in the language at some later time. gulpfile.js
contains build instructions. Build with npm run build. The dist/
folder contains what will be published on npm.

Interfaces are implemented as classes with decorators specifying the
properties of the member that is exported on the bus.

Update examples and add a new tracklist example.

Other bugfixes may have been a side effect of the rewrite.

fixes #1
fixes #6
fixes #13

@acrisci acrisci changed the title Migrate to dbus-next [POC] Migrate to dbus-next Nov 8, 2018
@acrisci
Copy link
Member Author

@acrisci acrisci commented Nov 8, 2018

I do believe this works, but dbus-next is not released yet so you'll have to wait for that to merge. No breaking changes in the api were intended. I think it works, but it should be tested a bit more.

I've talked to @sidorares and he said he is interested in merging the service interface of dbus-next. So consider this a reference implementation.

Migration to dbus-next (a fork of dbus-native) is a rewrite, but fixes
some outstanding bugs in the project related to variant types.

The project is now transpiled to use the experimental decorator feature
that will be available in the language at some later time. gulpfile.js
contains build instructions. Build with `npm run build`. The dist/
folder contains what will be published on npm.

Interfaces are implemented as classes with decorators specifying the
properties of the member that is exported on the bus.

Update examples and add a new tracklist example.

Other bugfixes may have been a side effect of the rewrite.

fixes dbusjs#1
fixes dbusjs#6
fixes dbusjs#13
@emersion
Copy link
Collaborator

@emersion emersion commented Dec 19, 2018

Any news about this?

@sidorares
Copy link

@sidorares sidorares commented Dec 19, 2018

@emersion sorry still didn't have any free time, maybe over holiday period

@emersion
Copy link
Collaborator

@emersion emersion commented Dec 19, 2018

No worries, and thanks for your hard work on dbus-native!

@acrisci
Copy link
Member Author

@acrisci acrisci commented Dec 19, 2018

Sorry for the rewrites. Can't wait to finally close my stupid playerctl bug.

@martpie
Copy link

@martpie martpie commented Mar 3, 2019

This would be absolutely awesome to have mpris-service based on node-dbus-next :D

@acrisci
Copy link
Member Author

@acrisci acrisci commented Mar 3, 2019

The last problem to solve is to get my required node engine version down to about 6.3 and then I can go about my glorious mission to fix javascript media players.

@acrisci acrisci changed the title [POC] Migrate to dbus-next Migrate to dbus-next Mar 4, 2019
@acrisci
Copy link
Member Author

@acrisci acrisci commented Mar 4, 2019

Hey @emersion this is ready for review.

Run npm run build to build the project to the dist folder.

Run tests with npm run test (they may be flaky the first few runs, but then they become stable for some reason).

Build docs to the doc folder with npm run doc

Copy link
Collaborator

@emersion emersion left a comment

There are still some TODOs, but I think it's better to merge this as-is. This LGTM.

Thanks for your hard work, that's quite impressive :)

@emersion emersion merged commit 7ca6311 into dbusjs:master Mar 4, 2019
@acrisci acrisci deleted the dbus-next branch Mar 4, 2019
@emersion emersion mentioned this pull request Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants