nfs: door should have a thread pool for message processing

new configuration properties and defaults :

nfs.cell.limits.message.threads.max=8
nfs.cell.limits.message.queue.max=1000

Acked-by: Paul Millar
Target: master
Require-book: no
Require-notes: yes

modules/dcache-nfs/src/main/resources/org/dcache/chimera/nfsv41/door/nfsv41-common.xml

@@ -183,6 +183,13 @@
         <property name="fsStatTimeUnit" value="${nfs.fs-stat-cache.time.unit}" />
     </bean>
 
+    <bean id="messageThreadPool" class="org.dcache.util.BoundedExecutor"
+        destroy-method="shutdown">
+        <description>Thread pool for message processing</description>
+        <constructor-arg value="${nfs.cell.limits.message.threads.max}"/>
+        <constructor-arg value="${nfs.cell.limits.message.queue.max}"/>
+    </bean>
+
     <beans  profile="portmap-true">
         <bean id="rpcbind" class="org.dcache.xdr.portmap.OncRpcEmbeddedPortmap"
 	    destroy-method="shutdown"/>

skel/share/defaults/nfs.properties

@@ -178,3 +178,10 @@ nfs.fs-stat-cache.time = 3600
 (forbidden)nfs.published.name = Use nfs.loginbroker.family
 (forbidden)nfs.service.loginbroker.family = Use nfs.loginbroker.family
 (forbidden)nfs.service.loginbroker.version = Use nfs.loginbroker.version
+#
+# NFS door message processing thread pool configuration
+#
+nfs.cell.limits.message.threads.max=8
+nfs.cell.limits.message.queue.max=1000
+
+(obsolete)nfs.db.driver=The property is not needed with JDBC 4 drivers

skel/share/services/nfs.batch

@@ -44,6 +44,8 @@ check -strong nfs.namespace-cache.time.unit
 check -strong nfs.namespace-cache.size
 check -strong pool.mover.nfs.port.min
 check -strong pool.mover.nfs.port.max
+check -strong nfs.cell.limits.message.threads.max
+check -strong nfs.cell.limits.message.queue.max
 check nfs.db.password
 check nfs.db.password.file
 check nfs.domain
@@ -52,5 +54,6 @@ check nfs.mover.queue
 create org.dcache.cells.UniversalSpringCell ${nfs.cell.name} \
         "classpath:org/dcache/chimera/nfsv41/door/nfsv41-common.xml \
             -export=${nfs.cell.export} \
+            -messageExecutor=messageThreadPool \
             -profiles=portmap-${nfs.enable.portmap}"