Merged
Conversation
Contributor
Author
|
|
cb89075 to
0e054cc
Compare
CodSpeed Performance ReportMerging #620 will not alter performanceComparing Summary
|
dcastil
approved these changes
Nov 2, 2025
Owner
dcastil
left a comment
There was a problem hiding this comment.
Nice, this is really cool! Thanks for the addition! Let's just fix the last ESLint issue so we can merge this.
Contributor
Author
|
Oh yeah it can just be removed
…On Sun, Nov 2, 2025 at 9:04 AM Dany Castillo ***@***.***> wrote:
***@***.**** approved this pull request.
Nice, this is really cool! Thanks for the addition! Let's just fix the
last ESLint issue so we can merge this.
------------------------------
In tests/tw-merge.benchmark.ts
<#620 (comment)>
:
> + */
+async function forceGarbageCollection(): Promise<void> {
+ if (typeof globalThis.gc === 'function') {
+ await globalThis.gc()
+ } else {
+ // eslint-disable-next-line no-console -- This is a warning that will be printed to the console if garbage collection is not exposed.
+ console.warn(
+ 'Garbage collection not exposed. Run with --expose-gc for accurate memory measurements.',
+ )
+ }
+}
+
+// Guard to ensure memory summary is printed exactly once. teardown() runs after every
+// benchmark iteration, so without this guard the summary would be printed multiple times
+// (once per iteration of the last benchmark).
+let summaryPrinted = false
Looks like this variable is not used anywhere. Maybe forgot to add the
logic or forgot to remove?
—
Reply to this email directly, view it on GitHub
<#620 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAELFVRVHXVGPEFOZZDYM7D32YFPTAVCNFSM6AAAAACKS2BC22VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTIMBYHAYDKMJVHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Owner
|
Alright, let me remove it |
Owner
|
This was addressed in release v3.4.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now with memory info:
The benchmark data should be a bit more accurate as well with some random memory fluctuations removed.