Skip to content

Conversation

@dcermak
Copy link
Owner

@dcermak dcermak commented Mar 29, 2021

This is a bit crude implementation of the document symbol capability leveraging the new AST.

Current drawbacks:

  • everything is stuffed into the AST classes (I think this is reasonable, but it could become a mess if we add all the capabalities into the node classes)
  • The selection range (range identifying the "main" symbol) is atm computed from the start of the node to start + len(identifier). This should be good enough, but maybe we should extract this information from the yaml parser?

@dcermak dcermak requested a review from cbosdo March 29, 2021 22:06
@dcermak dcermak force-pushed the document_symbol_providing branch 3 times, most recently from ff42c40 to 5337530 Compare April 2, 2021 13:12
@dcermak dcermak force-pushed the document_symbol_providing branch from 5337530 to fe20461 Compare April 6, 2021 21:46
@dcermak dcermak force-pushed the document_symbol_providing branch from fe20461 to eaea3e6 Compare April 6, 2021 21:48
Copy link
Collaborator

@cbosdo cbosdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dcermak dcermak merged commit b28cd36 into main Apr 7, 2021
@dcermak dcermak deleted the document_symbol_providing branch April 7, 2021 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants