Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Final Pre-MVP Contract Review #133

Closed
3 tasks
apbendi opened this issue Aug 23, 2021 · 3 comments · Fixed by #192
Closed
3 tasks

Final Pre-MVP Contract Review #133

apbendi opened this issue Aug 23, 2021 · 3 comments · Fixed by #192
Assignees
@mds1
Labels
contracts Smart contract issues

Comments

@apbendi
Copy link
Collaborator

apbendi commented Aug 23, 2021

  • Internal
    • Test coverage -> 100%
  • 3rd Party
@apbendi apbendi added the contracts Smart contract issues label Aug 23, 2021
@mds1
Copy link
Contributor

mds1 commented Aug 23, 2021

Probably should also check out #98 as part of this

@mds1 mds1 mentioned this issue Sep 7, 2021
Merged
@mds1 mds1 self-assigned this Sep 8, 2021
@mds1
Copy link
Contributor

mds1 commented Sep 8, 2021

Also address: #171 (comment)

@apbendi
Copy link
Collaborator Author

apbendi commented Sep 8, 2021

Also want to remove the minContribution field for now, since it's not needed as part of the POC, though eventually we'll want to add it back per #187.

@mds1 mds1 mentioned this issue Sep 9, 2021
Merged
@mds1 mds1 closed this as completed in #192 Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mds1 mds1

Labels
contracts Smart contract issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Contract cleanup dcgtc/dgrants
2 participants
@apbendi @mds1