Explictly stub valid? in mock_model #18

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants

It's not uncommon to check if the model is valid, and this is mocked by default in newer rspec-rails as well (rspec/rspec-rails@a10c402). I think it might be useful to backport.

Owner

dchelimsky commented Aug 16, 2012

Thanks for the pull request, but we're not doing any releases of rspec-1 at this point except for bug fixes.

dchelimsky closed this Aug 16, 2012

Hi David,

That's sad. Even one-line changes? I know that Rails 3 has been out for a
while, but there's still many projects stuck in Rails 2.3 (mine included),
and I feel this is a useful change.

Anyway, thanks for the quick response :-)

Cheers!
Vítor.

2012/8/16 David Chelimsky notifications@github.com

Thanks for the pull request, but we're not doing any releases of rspec-1
at this point except for bug fixes.


Reply to this email directly or view it on GitHubhttps://github.com/dchelimsky/rspec-rails/pull/18#issuecomment-7784684.

Owner

dchelimsky commented Aug 16, 2012

The issue is not the size of the change. It's the overhead and risk involved with any release. If this were to break anything upstream I'd have to roll it back, and I don't even have the time to keep up w/ the demands of rspec-2 these days.

I understand. I'll workaround this, then. Thanks for your hard work :-)

2012/8/16 David Chelimsky notifications@github.com

The issue is not the size of the change. It's the overhead and risk
involved with any release. If this were to break anything upstream I'd have
to roll it back, and I don't even have the time to keep up w/ the demands
of rspec-2 these days.


Reply to this email directly or view it on GitHubhttps://github.com/dchelimsky/rspec-rails/pull/18#issuecomment-7789211.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment