Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Attempted to fix #6227, not entirely sure if it's a problem as I'm ha…

…ving a hard time reproducing it. Regardless, the change is harmless and potentially even speeds up appendTo, etc. slightly.
  • Loading branch information...
commit 2c08004f6d4e7f11a875190e132d204a25cb9418 1 parent 9584e90
@jeresig jeresig authored
Showing with 10 additions and 2 deletions.
  1. +1 −1  src/manipulation.js
  2. +9 −1 test/unit/manipulation.js
View
2  src/manipulation.js
@@ -442,7 +442,7 @@ jQuery.each({
} else {
for ( var i = 0, l = insert.length; i < l; i++ ) {
var elems = (i > 0 ? this.clone(true) : this).get();
- jQuery.fn[ original ].apply( jQuery(insert[i]), elems );
+ jQuery.fn[ original ].call( jQuery(insert[i]), elems );
ret = ret.concat( elems );
}
View
10 test/unit/manipulation.js
@@ -376,7 +376,7 @@ test("append(Function) with incoming value", function() {
});
test("appendTo(String|Element|Array&lt;Element&gt;|jQuery)", function() {
- expect(14);
+ expect(16);
var defaultText = 'Try them out:'
jQuery('<b>buga</b>').appendTo('#first');
@@ -384,6 +384,14 @@ test("appendTo(String|Element|Array&lt;Element&gt;|jQuery)", function() {
equals( jQuery('<option value="appendTest">Append Test</option>').appendTo('#select3').parent().find('option:last-child').attr('value'), 'appendTest', 'Appending html options to select element');
reset();
+ var l = jQuery("#first").children().length + 3;
+ jQuery("body").map(function(){
+ return jQuery("<strong></strong><b></b><b></b>").get();
+ }).appendTo("p");
+ equals( jQuery("#first").children().length, l, "Make sure the elements were inserted." );
+ equals( jQuery("#first").children().last()[0].nodeName.toLowerCase(), "b", "Verify the last element." );
+
+ reset();
var expected = "This link has class=\"blog\": Simon Willison's WeblogTry them out:";
jQuery(document.getElementById('first')).appendTo('#sap');
equals( expected, jQuery('#sap').text(), "Check for appending of element" );
Please sign in to comment.
Something went wrong with that request. Please try again.