Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
branch: master
Commits on Aug 24, 2014
  1. Post-merge

    authored
  2. Merge pull request #7 from keunwoo/master

    authored
    +require.main
  3. @keunwoo

    +require.main

    keunwoo authored
    This is present and equal to module when a module is run as main:
    http://nodejs.org/api/modules.html#modules_accessing_the_main_module
Commits on Aug 23, 2014
  1. Post-merge

    authored
  2. Merge pull request #6 from keunwoo/master

    authored
    update fs.{read,write}File{,Sync} decls
  3. @keunwoo

    update fs.{read,write}File{,Sync} decls

    keunwoo authored
    In current (0.10.31) node, these functions take an options object as
    their second parameter, not a string.  I'm not sure when this was
    changed, although I think it happened many versions ago.
    
    http://nodejs.org/api/fs.html#fs_fs_readfile_filename_options_callback
    http://nodejs.org/api/fs.html#fs_fs_readfilesync_filename_options
    http://nodejs.org/api/fs.html#fs_fs_writefile_filename_data_options_callback
    http://nodejs.org/api/fs.html#fs_fs_writefilesync_filename_data_options
    
    The string form has been left as an alternative for users who are using
    old versions of node.
Commits on Jul 6, 2014
  1. Use 0.10 with travis

    authored
  2. Merge pull request #4 from nicks/master

    authored
    Fix the util.inspect contract
Commits on Mar 6, 2014
  1. @nicks

    Fix the util.inspect contract

    nicks authored
Commits on Aug 14, 2013
  1. Versioning

    authored
  2. Typo, fixes #3

    authored
Commits on Apr 13, 2013
  1. @kevinoid

    Merge pull request #2 from kevinoid/fix-some-type-errors

    kevinoid authored
    Fix type errors
  2. @kevinoid

    Remove @nosideeffects from fs functions with callback

    kevinoid authored
    The side-effectfulness of these functions is determined based on whether
    the callback function has side-effects.  Presumably it does (what's the
    point of the callback otherwise?).  So remove the @nosideeffects
    annotation.
    
    Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
  3. @kevinoid

    Remove @nosideeffects from buffer.Buffer.prototype.copy

    kevinoid authored
    The side-effect of this method is copying data into the target buffer
    given as an argument.
    
    Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
  4. @kevinoid

    Match stream.WritableStream.end to stream.Writable.end

    kevinoid authored
    Until we decide what to do with WritableStream, fix it to avoid
    producing any warnings.
    
    Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
  5. @kevinoid

    Remove Object.prototype.inspect

    kevinoid authored
    I'm not sure if this used to be added by node, but I can't find it
    anywhere in the docs or code in recent versions.  It was also causing
    the following warning (due to a conflict with util.inspect):
    
    ./util.js:77: WARNING - assignment to property inspect of Object.<string,*>
    found   : function (*, boolean=, number=, boolean=): string
    required: function (this:Object): ?
    util.inspect = function(object, showHidden, depth, colors) {};
    ^
    
    Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
  6. @kevinoid

    Remove unnecessary members from tls.Server

    kevinoid authored
    These members are all inherited from net.Server and don't need to be
    redefined for tls.Server (and the listen definition was causing type
    warnings).
    
    Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
  7. @kevinoid

    Update crypto module

    kevinoid authored
    Lots of refactoring to work around the fact that Closure Compiler
    doesn't have proper support for mixins.  Ensure that @extends meets the
    requirement that X instanceof Y if X @extends Y.  Add copies of the
    annotations for all mixin methods and aliased functions.
    
    Also add missing annotations for pbkdf2.
    
    Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
  8. @kevinoid

    Replace ServerRequest/ClientResponse with IncomingMessage

    kevinoid authored
    Replace the http.ServerRequest and http.ClientResponse classes with the
    IncomingMessage class, as is done in recent versions of node.  Add the
    missing members to the prototype.
    
    Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
  9. @kevinoid

    Remove number assignment to Date properties

    kevinoid authored
    The properties of Stat with Date type were being assigned numbers, which
    caused compile warnings.  Remove the unnecessary assignment.
    
    Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
  10. @kevinoid

    Add Date type to time arguments in fs

    kevinoid authored
    All of the functions which take a time argument accept either numbers
    (as seconds since the epoch) or a Date.  Add the Date type to arguments
    where it was missing.
    
    Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
  11. @kevinoid

    Major reworking of streams

    kevinoid authored
    Update the annotations to match their definitions in node 0.10.  Also,
    stream (the namespace) is not a class, use stream.Stream instead as
    appropriate.
    
    This commit doesn't fix the multiple inheritance/mixin issue with Duplex
    needing to extend from both Readable and Writable.  This may require
    defining some interfaces which can be implemented.
    
    This commit also doesn't touch ReadableStream and WritableStream.  I'm
    not sure of the purpose of these classes and since they are heavily used
    in other namespaces, I'll leave them alone for now.
    
    Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
  12. @kevinoid

    Fix type of module.require

    kevinoid authored
    Although it has the same type as the global require function, the global
    require function isn't a type (constructor).  So update the type of
    module.require to match it.  This fixes the following warning:
    
    ./core.js:76: WARNING - Bad type annotation. Unknown type require
     * @type {require}
              ^
    
    Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
  13. @kevinoid

    Make options argument of child_process.fork optional

    kevinoid authored
    According to the docs (and code) this argument is optional.  This also
    fixes the warning about non-optional arguments following optional
    arguments.
    
    Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
  14. @kevinoid

    Fix type of cluster

    kevinoid authored
    cluster is actually an instance of the private Cluster type, which
    extends EventEmitter.  Therefore, annotate cluster as being of type
    EventEmitter.
    
    Note:  This code is now not runnable, since assigning to cluster would
    require either reference to the events namespace (which isn't imported)
    or leaving it null which would fail for subsequent property accesses.
    But that's fine, since externs aren't run.
    
    Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
  15. @kevinoid

    Buffer doesn't extend Array

    kevinoid authored
    From source inspection and usage, it's clear that Buffer doesn't extend
    Array (for example, Buffer has no pop method).  Remove this annotation
    (which also fixes the type incompatibility of the slice method).
    
    Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
  16. @kevinoid

    Fix unqualified uses of the buffer.Buffer type

    kevinoid authored
    The type requires the buffer namespace in order to be resolved.  Add it
    where missing.
    
    Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
  17. @kevinoid

    Fix typos in type annotations

    kevinoid authored
    The intent of these annotations seems clear, fix the typos.
    
    Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
  18. @kevinoid

    Fix capitalization of Array and Object types

    kevinoid authored
    Array and Object were often written as array and object, causing
    warnings such as:
    
    ./buffer.js:32: WARNING - Bad type annotation. Unknown type object
     * @type {object.<string,*>}
              ^
    
    Fix the warnings by correcting the capitalization.
    
    Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
Commits on Apr 12, 2013
  1. Better validation, will break the tests

    Daniel Wirtz authored
  2. Merge pull request #1 from kevinoid/fix-some-verbose-warnings

    authored
    Fix some of the warning messages produced at verbose warning level
  3. @kevinoid

    Fix multiple @extends in stream.js

    kevinoid authored
    It's not possible to @extends two different classes (see
    http://code.google.com/p/closure-compiler/issues/detail?id=250).  This
    was causing the following error:
    
    stream.js:209: WARNING - Bad type annotation. type annotation incompatible with other annotations
     * @extends stream.Writable
                               ^
    
    From source inspection, Duplex extends Readable and implements Writable.
    Update the annotations to reflect this.
    
    Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
Something went wrong with that request. Please try again.