New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add imports to generated .d.ts file #596

Closed
ehallander9591 opened this Issue Dec 29, 2016 · 4 comments

Comments

Projects
None yet
4 participants
@ehallander9591

ehallander9591 commented Dec 29, 2016

protobuf.js version: 6.3.1

Using the pbts tool and WebStorm doesn't like the generated .d.ts file unless I manually add the following lines at the top of the file

import {Writer} from 'protobufjs';
import {Reader} from 'protobufjs';

@jeffgrossmann

This comment has been minimized.

jeffgrossmann commented Dec 29, 2016

Is it issue with WebStorm of the typescript compiler?

@ehallander9591

This comment has been minimized.

ehallander9591 commented Dec 29, 2016

It would seem that any external package references in the generated .d.ts file would need some sort of reference. Webstorm complains, because tsc complains.

dcodeIO added a commit that referenced this issue Dec 30, 2016

@vanishs

This comment has been minimized.

Contributor

vanishs commented Dec 30, 2016

Also need to add 'Method'.

@dcodeIO

This comment has been minimized.

Owner

dcodeIO commented Jan 3, 2017

Closing this for now as 6.4.0, which is now released, should solve the issue. Feel free to reopen the issue if necessary.

@dcodeIO dcodeIO closed this Jan 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment