New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typings: micro-modules need types! #599

Closed
paralin opened this Issue Dec 30, 2016 · 5 comments

Comments

Projects
None yet
2 participants
@paralin

paralin commented Dec 30, 2016

Typings files need to be included for your micro-modules, like @protobufjs/base64

@dcodeIO

This comment has been minimized.

Owner

dcodeIO commented Dec 30, 2016

Do you get any error or are you using the modules directly?

dcodeIO added a commit that referenced this issue Dec 30, 2016

@dcodeIO

This comment has been minimized.

Owner

dcodeIO commented Dec 30, 2016

I copy-pasted these now but didn't verify whether this is working without additional modifications.

@dcodeIO dcodeIO added the enhancement label Dec 30, 2016

dcodeIO added a commit that referenced this issue Dec 30, 2016

@dcodeIO

This comment has been minimized.

Owner

dcodeIO commented Dec 30, 2016

Updated to mirror what I hope to be improvements within a7d2324

@paralin

This comment has been minimized.

paralin commented Dec 30, 2016

Yeah, you need index.d.ts for each module. I was using them directly. Furthermore I've had a lot of issues with having the typings in the typings subdirectory instead of next to index.js as index.d.ts so I'm glad you've made that change.

@dcodeIO

This comment has been minimized.

Owner

dcodeIO commented Jan 3, 2017

Closing this for now as 6.4.0, which is now released, should solve the issue. Feel free to reopen the issue if necessary.

@dcodeIO dcodeIO closed this Jan 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment