New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idempotent pbjs output generation #614

Closed
r-tock opened this Issue Jan 3, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@r-tock
Contributor

r-tock commented Jan 3, 2017

We rely on pre-commit hooks, every time the pbjs is run, we expect same output. Can there be an --idempotent flag that strips out.

+// Generated Tue, 03 Jan 2017 22:32:22 UTC
@r-tock

This comment has been minimized.

Contributor

r-tock commented Jan 3, 2017

Also these comments are causing webpack json-loader to barf. As it is no longer a valid json object

dcodeIO added a commit that referenced this issue Jan 3, 2017

@dcodeIO dcodeIO added the enhancement label Jan 3, 2017

@r-tock r-tock closed this Jan 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment