Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Do something better for calling Proto.from with a proto instead of a JSON. Currently all unset fields get expanded #652
referenced this issue
Jan 19, 2017
Gah!!! Found it. Somewhere in our code we are passing protoObj into a MyProto.from(protoObj) instead of JSON. the
Can you help identify such bad call sites and throw a console.warn or fatal error or something. Or maybe do something smarter.
I think V5 handled this correctly in the contructor. Now in V6, I mechanically changed the ctor to from(), didn't realize this folly.