New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix directly using Buffer instead of util.Buffer #571

Merged
merged 1 commit into from Dec 18, 2016

Conversation

Projects
None yet
2 participants
@fnlctrl
Contributor

fnlctrl commented Dec 18, 2016

This seems to have caused webpack to load a Buffer shim when building for web.

Fix directly using Buffer instead of util.Buffer
This seems to have caused webpack to load a Buffer shim.

@dcodeIO dcodeIO merged commit ccc5de1 into dcodeIO:master Dec 18, 2016

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@dcodeIO

This comment has been minimized.

Owner

dcodeIO commented Dec 18, 2016

Thanks!

@fnlctrl fnlctrl deleted the fnlctrl:patch-2 branch Dec 18, 2016

@dcodeIO

This comment has been minimized.

Owner

dcodeIO commented Dec 18, 2016

Btw, doesn't this cause the same?

@fnlctrl

This comment has been minimized.

Contributor

fnlctrl commented Dec 18, 2016

Yes, this PR didn't solve the problem, and I forgot to leave a comment here.
Since it's dynamic require, I can't seem to think of a way to properly solve it.. So as a workaround, I now use webpack.IgnorePlugin to force disable loading Buffer/Long.

plugins: [
    new webpack.IgnorePlugin(/^long$/),
    new webpack.IgnorePlugin(/^buffer$/)
]

dcodeIO added a commit that referenced this pull request Dec 18, 2016

@dcodeIO

This comment has been minimized.

Owner

dcodeIO commented Dec 18, 2016

This now uses a dynamic require for all optional modules including buffer and long. Give it a shot!

@fnlctrl

This comment has been minimized.

Contributor

fnlctrl commented Dec 18, 2016

Works like a charm! Thanks for the awesome work! 👍👍👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment