chore(deps): update all to v4 (major) #245
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeorgiSTodorov
previously approved these changes
Oct 30, 2018
mesosphere-web
force-pushed
the
renovate/major-all
branch
2 times, most recently
from
e6e3c2a
to
4a47409
Compare
GeorgiSTodorov
previously approved these changes
Oct 31, 2018
Poltergeist
suggested changes
Nov 2, 2018
There was a problem hiding this comment.
This fails on my machine while running npm start with
ERR! Error: Cannot find module 'babel-loader/package.json' from '.../ui-kit'
ERR! at module.exports (.../ui-kit/node_modules/resolve/lib/sync.js:43:15)
ERR! at isBabelLoader8 (.../ui-kit/node_modules/@storybook/core/dist/server/loadCustomBabelConfig.js:68:52)
ERR! at _default (.../ui-kit/node_modules/@storybook/core/dist/server/loadCustomBabelConfig.js:88:10)
ERR! at Object.babel (.../ui-kit/node_modules/@storybook/core/dist/server/core-preset-dev.js:36:45)
ERR! at accumulationPromise.then.newConfig (.../ui-kit/node_modules/@storybook/core/dist/server/presets.js:73:72)
ERR! at process._tickCallback (internal/process/next_tick.js:68:7)
ERR! { Error: Cannot find module 'babel-loader/package.json' from '.../ui-kit'
ERR! at module.exports (.../ui-kit/node_modules/resolve/lib/sync.js:43:15)
ERR! at isBabelLoader8 (.../ui-kit/node_modules/@storybook/core/dist/server/loadCustomBabelConfig.js:68:52)
ERR! at _default (.../ui-kit/node_modules/@storybook/core/dist/server/loadCustomBabelConfig.js:88:10)
ERR! at Object.babel (.../ui-kit/node_modules/@storybook/core/dist/server/core-preset-dev.js:36:45)
ERR! at accumulationPromise.then.newConfig (.../ui-kit/node_modules/@storybook/core/dist/server/presets.js:73:72)
ERR! at process._tickCallback (internal/process/next_tick.js:68:7)
ERR! stack:
ERR! 'Error: Cannot find module \'babel-loader/package.json\' from \'.../ui-kit\'\n at module.exports (.../ui-kit/node_modules/resolve/lib/sync.js:43:15)\n at isBabelLoader8 (.../ui-kit/node_modules/@storybook/core/dist/server/loadCustomBabelConfig.js:68:52)\n at _default (.../ui-kit/node_modules/@storybook/core/dist/server/loadCustomBabelConfig.js:88:10)\n at Object.babel (.../ui-kit/node_modules/@storybook/core/dist/server/core-preset-dev.js:36:45)\n at accumulationPromise.then.newConfig (.../ui-kit/node_modules/@storybook/core/dist/server/presets.js:73:72)\n at process._tickCallback (internal/process/next_tick.js:68:7)',
ERR! code: 'MODULE_NOT_FOUND' }
98311cb
to
366c0ed
Compare
|
@Poltergeist Same for me. I think it is the same issue as storybookjs/storybook#4672. https://github.com/storybooks/storybook/blob/master/MIGRATION.md |
|
From https://github.com/storybooks/storybook/blob/master/MIGRATION.md#babel-7 didn't work for me, we need to look into this further. |
GeorgiSTodorov
previously approved these changes
Nov 7, 2018
There was a problem hiding this comment.
@Poltergeist Can you check again, both tests and start work for me now.
PR has been edited👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over then you can add the label |
nLight
force-pushed
the
renovate/major-all
branch
from
266c9d7
to
0aaafc8
Compare
|
Added babel, still not enough |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
3.4.11->4.0.43.4.11->4.0.43.4.11->4.0.43.4.11->4.0.43.4.11->4.0.43.4.11->4.0.43.4.11->4.0.43.4.11->4.0.4Release Notes
storybooks/storybook
v4.0.4Compare Source
2018-November-06
Bug Fixes
Array#sortcorrectly #4720Dependency Upgrades
v4.0.3Compare Source
2018-November-06
Bug Fixes
Maintenance
masterbecomes the stable branch #4719Dependency Upgrades
30 PRs
v4.0.2Compare Source
2018-October-31
Fix broken 4.0.1 release
Bug Fixes
v4.0.1Compare Source
2018-October-31
Broken release -
@storybook/client-loggersomehow didn't get published to NPM.v4.0.0Compare Source
2018-October-29
Storybook 4.0 is our first major-version update in over a year! Key improvements include:
There are hundreds of more fixes, features, and tweaks in the 4.0 release. See changelogs for
4.0.0-rc.*and4.0.0-alpha.*for details; check out our migration guide for a walkthrough of how to upgrade or themigration docs for an enumeration of breaking changes.
Renovate configuration
📅 Schedule: At any time (no schedule defined).
🚦 Automerge: Enabled.
♻️ Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "
rebase!".🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR has been generated by Renovate Bot.