Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove requests logging #119

Merged
merged 1 commit into from Jun 11, 2019

Conversation

Projects
None yet
4 participants
@janisz
Copy link
Contributor

commented Jun 10, 2019

Logging all request is not necessary when we have metrics. Requests logs are polluting logs and it's harder to find interesting information. The same data can be obtained with metrics.

Reverts: c139d76
Fixes: https://jira.mesosphere.com/browse/DCOS_OSS-5256

Remove requests logging
Logging all request is not necessary when we have metrics.
Requests logs are polluting logs and it's hareder to find interesting
information. The same data can be obtained with metrics.

Reverts: c139d76

@janisz janisz requested review from makkes, br-lewis and drewvanstone Jun 10, 2019

@janisz janisz requested a review from dcos/cluster-ops-fnd as a code owner Jun 10, 2019

@bgalek

bgalek approved these changes Jun 10, 2019

@makkes

makkes approved these changes Jun 11, 2019

@janisz janisz merged commit 728caa0 into master Jun 11, 2019

6 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/jenkins/branch This commit looks good
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@janisz janisz deleted the DCOS_OSS-5256/remove_http_access_log branch Jun 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.