Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coreos update 1.10 #2552

Closed
wants to merge 4 commits into from

Conversation

Projects
None yet
3 participants
@mellenburg
Copy link

mellenburg commented Mar 2, 2018

High-level description

This PR updates the coreOS version in the DC/OS simple templates to 1632 and also fixes the work around in the systemd unit that was not previously active

Corresponding DC/OS tickets (obligatory)

Checklist for all PRs

Checklist for component/package updates:

If you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath packages), then in addition to the above please also include:

  • Change log from the last version integrated (this should be a link to commits for easy verification and review): example
  • Test Results: [link to CI job test results for component]
  • Code Coverage (if available): [link to code coverage report]

PLEASE FILL IN THE TEMPLATE ABOVE / DO NOT REMOVE ANY SECTIONS ABOVE THIS LINE

Instructions and review process

What is the review process and when will my changes land?

All PRs require 2 approvals using GitHub's pull request reviews.

Reviewers should be:

  • Developers who understand the code being modified.
  • Developers responsible for code that interacts with or depends on the code being modified.

It is best to proactively ask for 2 reviews by @mentioning the candidate reviewers in the PR comments area. The responsibility is on the developer submitting the PR to follow-up with reviewers and make sure a PR is reviewed in a timely manner. Once a PR has 2 ship-it's, no red reviews, and all tests are green it will be included in the next train.

@mesosphere-mergebot

This comment has been minimized.

Copy link
Collaborator

mesosphere-mergebot commented Mar 2, 2018

This repo has @mesosphere-mergebot integration. You can interact with the following commands.

@mesosphere-mergebot merge-it  
@mesosphere-mergebot pr-status-checks  
@mesosphere-mergebot ship_it_label_status_check  
@mesosphere-mergebot override-status  
@mesosphere-mergebot bump-ee  
@mesosphere-mergebot label [Ship It |Request For Comment |Holding |Work In Progress |Ready For Review] 
  • PR creators can apply one of [Ready For Review |Work In Progress]. Owners can apply any label.
@mellenburg

This comment has been minimized.

Copy link
Author

mellenburg commented Mar 2, 2018

@mesosphere-mergebot

This comment has been minimized.

Copy link
Collaborator

mesosphere-mergebot commented Mar 2, 2018

Michael Ellenburg added some commits Mar 2, 2018

Michael Ellenburg
Michael Ellenburg
Michael Ellenburg
Michael Ellenburg

@mellenburg mellenburg force-pushed the mellenburg:coreos_update_1.10 branch from 70a2dd0 to 41ca792 Mar 30, 2018

@orsenthil orsenthil closed this May 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.