Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] Fix a metrics module installation bug when overlay network is disabled. #3735

Merged
merged 1 commit into from Nov 30, 2018

Conversation

greggomann
Copy link
Contributor

@greggomann greggomann commented Nov 7, 2018

High-level description

This PR fixes an issue in dcos-config.yaml which breaks the metrics Mesos module when the overlay network has been disabled at install time.

Corresponding DC/OS tickets (obligatory)

These DC/OS JIRA ticket(s) must be updated (ideally closed) in the moment this PR lands:

  • DCOS_OSS-4521 Metrics Mesos module fails to load if overlay network is disabled

Checklist for all PRs

  • Added a comprehensible changelog entry to CHANGES.md or explain why this is not a user-facing change:
  • Included a test which will fail if code is reverted but test is not. If there is no test please explain here:
  • Read the DC/OS contributing guidelines
  • Followed relevant code rules Rules for Packages and Systemd

Checklist for component/package updates:

If you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath packages), then in addition to the above please also include:

  • Change log from the last version integrated (this should be a link to commits for easy verification and review): example
  • Test Results: [link to CI job test results for component]
  • Code Coverage (if available): [link to code coverage report]

@d2iq-mergebot
Copy link
Collaborator

This repo has @mesosphere-mergebot integration. You can interact with the following commands.

@mesosphere-mergebot override-status pr-status-check jira-url 
@mesosphere-mergebot sync  
@mesosphere-mergebot merge-it  
@mesosphere-mergebot bump-ee  
@mesosphere-mergebot label [Ready For Review |Ship It |Holding |Work In Progress |Request For Comment] 
  • PR creators can apply one of [Ready For Review |Work In Progress]. Owners can apply any label.

lava
lava previously approved these changes Nov 8, 2018
@greggomann
Copy link
Contributor Author

@mesosphere-mergebot bump-ee

@d2iq-mergebot
Copy link
Collaborator

Your pull request's branch is not based on the most recent version of master. Please rebase your changes against this repo's master branch.

@greggomann
Copy link
Contributor Author

@mesosphere-mergebot bump-ee

@d2iq-mergebot
Copy link
Collaborator

Enterprise Bump PR: mesosphere/dcos-enterprise/pull/3841

@greggomann
Copy link
Contributor Author

@mesosphere-mergebot bump-ee

@d2iq-mergebot
Copy link
Collaborator

Your pull request's branch is not based on the most recent version of master. Please rebase your changes against this repo's master branch.

@greggomann greggomann changed the title Fix a metrics module installation bug when overlay network is disabled. [master] Fix a metrics module installation bug when overlay network is disabled. Nov 26, 2018
@greggomann
Copy link
Contributor Author

@mesosphere-mergebot bump-ee

@d2iq-mergebot
Copy link
Collaborator

Enterprise Bump mesosphere/dcos-enterprise/pull/3841 updated.

@greggomann
Copy link
Contributor Author

@mesosphere-mergebot label Ready For Review

d2iq-mergebot added a commit to mesosphere/dcos that referenced this pull request Nov 29, 2018
d2iq-mergebot added a commit to mesosphere/dcos that referenced this pull request Nov 29, 2018
@jgehrcke jgehrcke merged commit 317cf58 into dcos:master Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
6 participants