This repository has been archived by the owner on Feb 9, 2021. It is now read-only.
Changed polyline to work with a list of edges instead of a wire. #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -996,7 +996,7 @@ def _findFromPoint(self, useLocalCoords=False): | |||
|
|
|||
There was a problem hiding this comment.
WARNING: only the last object in the stack is used.
|
I make some comments because I don't know how to change the file directly. |
|
@galou I think you could fork my branch to make changes and then do a PR for that branch, but I'm not exactly sure how/if that works. The comments worked just fine though. Thank you for the feedback. I've incorporated your changes. |
jmwright
added a commit
that referenced
this pull request
Oct 14, 2015
Changed polyline to work with a list of edges instead of a wire.
jmwright
added a commit
that referenced
this pull request
Oct 14, 2015
|
@jmwright I also though I could fork the branch but I don't know how to avoid submitting a new PR when I want the changes to be integrated. I would rather reuse the same PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rework of the polyline function to fix issue #102
If someone like @dcowden @hyOzd or @galou wants to look over my code, that would be great. Otherwise I'll just merge after waiting awhile for comments.