fixes infinate recursion on django 1.6 #96

Merged
merged 7 commits into from Jan 13, 2014

Projects

None yet

6 participants

fadur commented Dec 19, 2013

Issue #92 made devserver unusable for anyone on 1.6

Owner
dcramer commented Dec 23, 2013

I don't want to merge this until I understand the behavior, but it's been a while since I've touched any of this code.

Will this not break behavior on older versions of Django?

fadur commented Dec 23, 2013

Fair enough.
Yes, you're right. I've submitted a quick patch.
Let me know how you wish to proceed.

Owner
dcramer commented Dec 23, 2013

I think this is good. Could you remove the print/extra spacing around the if statement?

Thanks!

fadur commented Dec 23, 2013

Should be fixed now.

There are still three extra empty lines (60-62); would love to see this merged though as I'm waiting to upgrade to 1.6.x for this. :)

@dcramer Any news on merging this?

@dcramer dcramer merged commit b65bee8 into dcramer:master Jan 13, 2014
Contributor

Hi @dcramer - do you know when you'd be able to get this fix onto PyPI as a new release?

Just in the processing of upgrading to Django 1.6 right now and have hit this. I'd ideally like to continue to install django-devserver from PyPI, rather than the github master branch, in my pip requirements.txt.

Cheers, Neal

@nealtodd 👍 that would help as well

foxx commented May 2, 2014

Any update on getting this PR into pip?? Would a bounty help?

Owner
dcramer commented May 2, 2014

Pushed 0.8.0

foxx commented May 2, 2014

Confirmed working in pip install django-devserver==0.8.0. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment