Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Updated 'no_shipping' and 'rm' options for PayPalPaymentsForm #21

Open
wants to merge 5 commits into
from

Conversation

Projects
None yet
1 participant

From was missing shipping option 2 which prompts the buyer for an address, and requires one before
payment is taken. Also it was missing PayPal 'rm' variable which specifies the return FORM method used
upon success payment:

Allowable values are:
0 . all shopping cart payments use the GET method
1 . the buyer.s browser is redirected to the return URL by using the GET method, but no payment variables are included
2 . the buyer.s browser is redirected to the return URL by using the POST method, and all payment variables are included

The default is 0. Note: The rm variable takes effect only if the return variable is set.

Added option 2 to 'no_shipping' and added paypal variable 'rm' support.
Shipping option 2 prompts the buyer for an address, and requires one before
payment is taken. PayPal 'rm' variable specifies the return FORM method used
upon success payment:

 Allowable values are:
  0 . all shopping cart payments use the GET method
  1 . the buyer.s browser is redirected to the return URL by using the GET method, but no payment variables are included
  2 . the buyer.s browser is redirected to the return URL by using the POST method, and all payment variables are included

 The default is 0. Note: The rm variable takes effect only if the return variable is set.

Hi @dcramer , I am doing another project and would like to use your fork but need the extra paypal parameters support. Are you going to merge this please?

Daniel Sokolowski added some commits Sep 4, 2012

Added `render_as_GET_url()`, `sandbox_as_GET_url()` methods and 'imag…
…e_url' header image support to form.

The method `<PayPalPaymentForm>.render_as_GET_url()` and it's sandbox version can be used
to directly redirect to PayPal payment page from view that performs pre-payment processing;
for example a view that check if shipping information was entered and is correct, to confirming
that inventory is still adequate for order. Readme documentation was updated to reflect these changes.
Changing from spaces to tabs; in practice better to manage than spaces.
For example in Eclipse one can enable "Show whitespace characters" which helps with code blocks and for this tabs are a better choice than spaces. Another plus once can easily specify 'tab' character visual length which you can't do for spaces; hence this developer uses tabs against 'PEP-8' strong recommendations.

pigletto pushed a commit to pigletto/django-paypal that referenced this pull request Aug 7, 2014

Merge pull request #21 from codingjoe/patch-1
fixes markup for signal documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment