Don't check against URLs in requirements files #6

Merged
merged 1 commit into from Aug 13, 2012

Conversation

Projects
None yet
2 participants
Contributor

lorin commented Aug 13, 2012

When downloading a Python package from, say, a zipfile using http,
pip will report the proper version number, but the requirements
file will have a URL, which will cause a mismatch.

As an example, consider requirements.txt that contains:

https://github.com/dcramer/piplint/zipball/master

pip freeze will report:

piplint==0.1.1

Running piplint will cause an error:

$ piplint requirements.txt

Requirement 'https://github.com/dcramer/piplint/zipball/master' not found in virtualenv.
You must correct your environment before committing (and running tests).

Don't check against http URLs.
When downloading a Python package from, say, a zipfile using http,
pip will report the proper version number, but the requirements
file will have a URL, which will cause a mismatch.

As an example, consider requirements.txt that contains:

https://github.com/dcramer/piplint/zipball/master

pip freeze will report:

piplint==0.1.1

Running piplint will cause an error:

$ piplint requirements.txt

Requirement 'https://github.com/dcramer/piplint/zipball/master' not found in virtualenv.
You must correct your environment before committing (and running tests).

dcramer added a commit that referenced this pull request Aug 13, 2012

Merge pull request #6 from nimbis/master
Don't check against URLs in requirements files

@dcramer dcramer merged commit 7d79018 into dcramer:master Aug 13, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment