Remove src directory so "pip freeze" reports correctly #9

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

lorin commented Nov 1, 2012

Remove the src dir and move src/piplint up one directory.

This is done so that "pip freeze" reports correctly when piplint
is installed using git.

Addresses issue #8.

@lorin lorin Remove src dir so piplint version reporting is correct
Remove the src dir and move src/piplint up one directory.

This is done so that "pip freeze" reports correctly when piplint
is installed using git.
c53705a
Owner

dcramer commented Nov 1, 2012

This shouldn't affect anything, and this is part of some modern standards we (some people in Disqus) follow for packaging python apps.

dcramer closed this Nov 1, 2012

Owner

dcramer commented Nov 1, 2012

@lorin were you just installing piplint from github because there hasnt been a release?

Contributor

lorin commented Nov 1, 2012

@dcramer Yes, I was looking for the -E functionality that is in the repo, but not in PyPi yet.

The proposed change is really a workaround for a bug in pip, which does not recognize that a package has been installed from git when it uses the "src" convention that piplint uses. (Basically, pip looks for the presence of $VENV/src/piplint/src/.git instead of $VENV/src/piplint/.git, doesn't find it, and concludes that piplint wasn't installed from a git repo)

I documented the behavior at #8 but it's really a pip problem. I'll file a bug with them.

In the meantime, I'm just installing from my own fork of piplint, but a new release would be even better.

Contributor

lorin commented Nov 1, 2012

Posted a bug to pip: pypa/pip#713

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment