diff --git a/sentry/contrib/logging/__init__.py b/sentry/contrib/logging/__init__.py index b4e6ba6..2e237fd 100644 --- a/sentry/contrib/logging/__init__.py +++ b/sentry/contrib/logging/__init__.py @@ -14,4 +14,4 @@ class SentryHandler(logging.Handler): def emit(self, record): - capture('Message', message=record.msg, params=record.args) + return capture('Message', message=record.msg, params=record.args) diff --git a/tests/test_clients/test_logging.py b/tests/test_clients/test_logging.py index 602e4b0..ba5363e 100644 --- a/tests/test_clients/test_logging.py +++ b/tests/test_clients/test_logging.py @@ -6,7 +6,7 @@ from sentry.models import Event class LoggingTest(BaseTest): - def test_logging_client(self): + def test_simple(self): client = get_client('sentry.client.logging.LoggingSentryClient') _foo = {'': None} diff --git a/tests/test_events.py b/tests/test_events.py index e21dfb4..5aabd5d 100644 --- a/tests/test_events.py +++ b/tests/test_events.py @@ -204,6 +204,12 @@ def test_message_event(self): self.assertEquals(event.type, 'sentry.events.Message') self.assertEquals(event.time_spent, 0) + self.assertTrue('sentry.interfaces.Message' in event.data) + event_data = event.data['sentry.interfaces.Message'] + self.assertTrue('message' in event_data) + self.assertEquals(event_data['message'], 'foo') + self.assertTrue('params' in event_data) + self.assertEquals(event_data['params'], []) def test_query_event(self): event_id = capture('Query', query='SELECT * FROM table', engine='psycopg2', time_spent=36)