Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

according to the docs, this should be a 404 #102

Merged
merged 1 commit into from May 19, 2018

Conversation

@categulario
Copy link
Contributor

@categulario categulario commented Mar 14, 2018

http://flask-pymongo.readthedocs.io/en/latest/#flask_pymongo.BSONObjectIdConverter

Moreover, I think it's more consistent to return a 404 than a 400 in such situation.

@dcrosta
Copy link
Owner

@dcrosta dcrosta commented May 19, 2018

Hah! Great catch, thanks! (Sorry it's taken me so long to get to this). Let me figure out how to get the build working again, then can try to merge this in -- hang tight!

@dcrosta dcrosta merged commit 4283ee1 into dcrosta:master May 19, 2018
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
@dcrosta
Copy link
Owner

@dcrosta dcrosta commented May 19, 2018

@categulario categulario deleted the categulario:categulario/raise-404 branch May 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.