New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added _id return from save_file and kwargs to be stored in the document #114
Conversation
Thanks for this! Looks like there's still some style tweaks to work out. Don't sweat the other build failures, I'll run this locally to ensure everything passes. Two things:
|
For the style, it wants you to format long call sites like:
and long function/method signatures like:
You can run Thanks again! |
Thanks for the feedback! I will make those changes. |
The style looks good now but I am getting an E999 error with the tox run. Do you know what that is? I think it has to do with the version of python on my machine, but I am not certain. If it is a version problem, I assume it will pass in Travis. |
Ah, I get it. Python 2 does not allow commas after I am just going to set the Sorry, this probably shouldn't have take so long to figure out. |
I’m on my phone so can’t look in detail now, but if there’s a way to disable that comma check after kwargs, I’d accept that change too. I haven’t run into that particular one with flake8 yet, but I’m sure someone on the internet has. |
I was able to get it to fit within the required column limit, so the style check passed. Would you prefer the multi-line way? The last Travis run only threw an error on |
I think the 3.4 build errors were unelated. I've merged this (manually) and will fix anything that breaks in case I was wrong. Thanks for the contribution! |
Sounds good; thanks! |
https://pypi.org/project/Flask-PyMongo/2.1.0/ now available, thanks again! |
Made some small changes to the
save_file
function. I added kwargs that will be placed into the document and returned the created document's _id.