New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use MongoClient and MongoReplicaSetClient #17

Closed
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@wsddn
Contributor

wsddn commented Dec 5, 2012

As of PyMongo 2.4 MongoClient and MongoReplicaSetClient are meant to be used instead of Connection and ReplicaSetConnection. This commit changes it. There is one problem, this won't work with PyMongo versions less than 2.4...

@dcrosta

This comment has been minimized.

Show comment
Hide comment
@dcrosta

dcrosta Dec 6, 2012

Owner

Thanks, I hadn't had time to review MongoClient yet.

We should update setup.py to require pymongo 2.4, and then clean out some of the support for older versions from init.py (like the switch around auto_start_request, and anything else I'm forgetting).

Owner

dcrosta commented Dec 6, 2012

Thanks, I hadn't had time to review MongoClient yet.

We should update setup.py to require pymongo 2.4, and then clean out some of the support for older versions from init.py (like the switch around auto_start_request, and anything else I'm forgetting).

@akhenakh

This comment has been minimized.

Show comment
Hide comment
@akhenakh

akhenakh Dec 13, 2012

Contributor

Hey guys, you could maybe look at this ticket on gunicorn but related to flask-pymongo benoitc/gunicorn#450

Contributor

akhenakh commented Dec 13, 2012

Hey guys, you could maybe look at this ticket on gunicorn but related to flask-pymongo benoitc/gunicorn#450

@wsddn

This comment has been minimized.

Show comment
Hide comment
@wsddn

wsddn Dec 14, 2012

Contributor

I've done a bit of housekeeping, so I've updated setup.py, removed some unneeded PyMongo stuff and updated the tests to reflect this. Hopefully this also solves benoitc/gunicorn#450 although this may need to be tested further.

Contributor

wsddn commented Dec 14, 2012

I've done a bit of housekeeping, so I've updated setup.py, removed some unneeded PyMongo stuff and updated the tests to reflect this. Hopefully this also solves benoitc/gunicorn#450 although this may need to be tested further.

@dcrosta dcrosta closed this in 632ff02 Dec 15, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment