New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure error is raised when URI database name is parsed as 'None'. #43

Merged
merged 1 commit into from Jan 17, 2015

Conversation

Projects
None yet
2 participants
@jeffbr13
Contributor

jeffbr13 commented Aug 22, 2014

You get a rather cryptic error when the MONGO_URI config value is missing a database path because uri_parser.parse_uri(app.config[key'URI']) returns {…, "database": None, …} and PyMongo.init_app(…) only checks for the non-existence of the "database" key.

This patch fixes that.

@dcrosta dcrosta merged commit dc37afb into dcrosta:master Jan 17, 2015

1 check failed

continuous-integration/travis-ci The Travis CI build could not complete due to an error
Details
@dcrosta

This comment has been minimized.

Show comment
Hide comment
@dcrosta

dcrosta Jan 17, 2015

Owner

Nice catch, thanks for the fix.

Owner

dcrosta commented Jan 17, 2015

Nice catch, thanks for the fix.

@dcrosta

This comment has been minimized.

Show comment
Hide comment
@dcrosta

dcrosta Apr 9, 2015

Owner

This is released in version 0.3.1 -- Thanks!

Owner

dcrosta commented Apr 9, 2015

This is released in version 0.3.1 -- Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment