New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set correct options from mongo uri parsed by pymongo #86

Merged
merged 1 commit into from May 22, 2017

Conversation

Projects
None yet
2 participants
@jbouzekri
Contributor

jbouzekri commented Jan 12, 2017

https://github.com/mongodb/mongo-python-driver/blob/master/pymongo/common.py#L465

Based on this mapping, we can see that pymongo lowercase the keyword and is not adding underscore

@dcrosta

This comment has been minimized.

Show comment
Hide comment
@dcrosta

dcrosta May 21, 2017

Owner

Hi @jbouzekri

Thanks for contributing this, and apologies for not having gotten back to you in so long. Ultimately, I don't think I'm going to merge this, because I suspect it would cause compatibility issues with PyMongo 2.x which current versions of Flask-PyMongo support.

Instead, I'm going to being working on Flask-PyMongo 2.0 which will drop support for all of the individual settings, and instead just take a URI -- that way it will support whatever options your version of PyMongo itself supports.

Owner

dcrosta commented May 21, 2017

Hi @jbouzekri

Thanks for contributing this, and apologies for not having gotten back to you in so long. Ultimately, I don't think I'm going to merge this, because I suspect it would cause compatibility issues with PyMongo 2.x which current versions of Flask-PyMongo support.

Instead, I'm going to being working on Flask-PyMongo 2.0 which will drop support for all of the individual settings, and instead just take a URI -- that way it will support whatever options your version of PyMongo itself supports.

@dcrosta

This comment has been minimized.

Show comment
Hide comment
@dcrosta

dcrosta May 22, 2017

Owner

Ah, sorry, please ignore my last comment -- I thought this was talking about keyword arguments to the MongoClient not values from the connection string. Appreciate the contribution.

Owner

dcrosta commented May 22, 2017

Ah, sorry, please ignore my last comment -- I thought this was talking about keyword arguments to the MongoClient not values from the connection string. Appreciate the contribution.

@dcrosta dcrosta merged commit 038fa5a into dcrosta:master May 22, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

This was referenced May 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment